feat(spanner): add samples for MR CMEK #14674

panerorenn9541 · 2024-08-29T18:25:25Z

Add samples for MR CMEK database creation, backup creation, copy backup, and backup restore.

This change is

snippet-bot · 2024-08-29T18:25:31Z

Here is the summary of changes.

You are about to add 4 region tags.

google/cloud/spanner/samples/samples.cc:1300, tag spanner_copy_backup_with_MR_CMEK
google/cloud/spanner/samples/samples.cc:1494, tag spanner_create_database_with_MR_CMEK
google/cloud/spanner/samples/samples.cc:1610, tag spanner_create_backup_with_MR_CMEK
google/cloud/spanner/samples/samples.cc:1725, tag spanner_restore_backup_with_MR_CMEK

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

conventional-commit-lint-gcf · 2024-08-29T18:25:41Z

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

scotthart

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @panerorenn9541)

google/cloud/spanner/samples/samples.cc line 1304 at r1 (raw file):

                std::string const& src_project_id,
                std::string const& src_instance_id,
                std::string const& src_backup_id,

This is a lot of parameters for a function. Perhaps define a struct

struct BackupIdentifier {
  std::string project_id;
  std::string instance_id;
  std::string backup_id;
};

void CopyBackupWithMRCMEK(google::cloud::spanner_admin::DatabaseAdminClient client,
    BackupIdentifier const& src,
    BackupIdentifier const& dst,
...

google/cloud/spanner/samples/samples.cc line 1320 at r1 (raw file):

          .get();
  if (!copy_backup) throw std::move(copy_backup).status();
  std::cout << "Copy Backup " << copy_backup->name()  //

Are these comment sequences needed?

google/cloud/spanner/samples/samples.cc line 1355 at r1 (raw file):

  auto expire_time = TimestampAdd(
      google::cloud::spanner::MakeTimestamp(backup->expire_time()).value(),
      absl::Hours(7));

Can we use std::chrono instead of absl here?

google/cloud/spanner/samples/samples.cc line 1614 at r1 (raw file):

void CreateBackupWithMRCMEK(
    google::cloud::spanner_admin::DatabaseAdminClient client,
    std::string const& project_id, std::string const& instance_id,

Same comment about excessive number of parameters.

google/cloud/spanner/samples/samples.cc line 1650 at r1 (raw file):

      std::cout << ", ";
    }
  }

We seem to do this several times. Perhaps factor this out into a function.

Code quote:

      << " using encryption keys ";
  for (int i = 0; i < encryption_keys.size(); ++i) {
    std::cout << encryption_keys[i].FullName();
    if (i != encryption_keys.size() - 1) {
      std::cout << ", ";
    }
  }

Use struct and create function to print kms keys

Use std::chrono instead of absl::hours

panerorenn9541

Reviewable status: 0 of 1 files reviewed, 5 unresolved discussions (waiting on @scotthart)

google/cloud/spanner/samples/samples.cc line 1304 at r1 (raw file):